Fix incorrect datetime string generation in NSISO8601DateFormatter #339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By default, the NSISO8601DateFormatter uses the NSISO8601DateFormatWithInternetDateTime formatting: https://github.com/gnustep/libs-base/blob/master/Headers/Foundation/NSISO8601DateFormatter.h#L57 This equates to these format options: ``` NSISO8601DateFormatWithYear | NSISO8601DateFormatWithMonth | NSISO8601DateFormatWithDay | NSISO8601DateFormatWithDashSeparatorInDate | NSISO8601DateFormatWithTime | NSISO8601DateFormatWithColonSeparatorInTime | NSISO8601DateFormatWithTimeZone | NSISO8601DateFormatWithColonSeparatorInTimeZone ``` The last option (`NSISO8601DateFormatWithColonSeparatorInTimeZone`) causes the formatter to append "ZZ:ZZ" to the formatting string. But ZZ maps to a timezone like this: “-0800" according to the ICU documentation: https://unicode-org.github.io/icu/userguide/format_parse/datetime/#date-field-symbol-table The full format string that GNUStep puts together with the above options is: "yyyy-MM-dd'T'HH:mm:ssZZ:ZZ" As a result, "ZZ:ZZ" will always translate to something like: “-0800:-0800” "ZZ:ZZ" should be "ZZZZZ" which is would output the timezone offset once with the `:` separator between hours and minutes. "yyyy-MM-dd'T'HH:mm:ssZZZZZ" is also the same format string used in Apple's implementation according to their documentation: https://developer.apple.com/documentation/foundation/nsiso8601dateformatter/1643114-init
kevinpeizner
changed the title
|
Looks good to me! It would be nice to have a test for this :) But I can write one as well. @rfm what do you think? |
|
I made a fix and added testcases based on this report a while back, but forgot about it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default, the
NSISO8601DateFormatteruses theNSISO8601DateFormatWithInternetDateTimeformatting:https://github.com/gnustep/libs-base/blob/master/Headers/Foundation/NSISO8601DateFormatter.h#L57
This equates to these format options:
The last option (
NSISO8601DateFormatWithColonSeparatorInTimeZone) causes the formatter to append "ZZ:ZZ" to the formatting string. But ZZ maps to a timezone like this: "-0800" according to the ICU documentation:https://unicode-org.github.io/icu/userguide/format_parse/datetime/#date-field-symbol-table
The full format string that GNUStep puts together with the above options is:
"yyyy-MM-dd'T'HH:mm:ssZZ:ZZ"
As a result, "ZZ:ZZ" will always translate to something like:
"-0800:-08:00"
"ZZ:ZZ" should be "ZZZZZ" which is would output the timezone offset once with the
:separator between hours and minutes."yyyy-MM-dd'T'HH:mm:ssZZZZZ" is also the same format string used in Apple's implementation according to their documentation: https://developer.apple.com/documentation/foundation/nsiso8601dateformatter/1643114-init