Tests/base/NSCalendar/era.m: Fix testing with non-English locale #357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the
NSCalendartests fail (at least on musl-based Alpine Linux v3.18) in the file Tests/NSCalendar/era.m if the locale is set to any non-English locale. For example, withthe ICU function
udat_parseused byNSDateFormatterreturns 9 (U_PARSE_ERROR) when passed the string containing English language month name (@"22 Nov 1969 08:15:00 Z"), which makes the tests fail.This patch explicitly sets the
NSDateFormatterlocale in Tests/NSCalendar/era.m toen_US.Solves part of the issues in #356.