Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix NSString ICU includes for Windows #404

Merged
merged 2 commits into from
May 15, 2024
Merged

Fix NSString ICU includes for Windows #404

merged 2 commits into from
May 15, 2024

Conversation

triplef
Copy link
Member

@triplef triplef commented May 14, 2024

Fixes building with the Windows-bundled ICU libraries (was broken with #370).

This wasn’t caught by CI because it’s still using Windows 2019 agents which don’t have the ICU library. I’ll open a separate PR to update this.

@triplef triplef requested a review from rfm as a code owner May 14, 2024 07:48
@triplef triplef marked this pull request as draft May 14, 2024 07:53
@triplef triplef force-pushed the fix-nsstring-icu branch 2 times, most recently from 304b819 to def86af Compare May 14, 2024 09:15
@triplef triplef force-pushed the fix-nsstring-icu branch from e0d1490 to 8844649 Compare May 15, 2024 09:38
@triplef triplef changed the title Fix NSString ICU includes and update Windows CI Fix NSString ICU includes for Windows May 15, 2024
@triplef triplef marked this pull request as ready for review May 15, 2024 11:57
Copy link
Contributor

@rfm rfm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That looks fine, thanks.

@triplef triplef merged commit 94a6cb9 into master May 15, 2024
10 checks passed
@triplef triplef deleted the fix-nsstring-icu branch May 15, 2024 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants