Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix broken enumerateSubstringsInRange:options:usingBlock: implementation #416

Merged
merged 2 commits into from
Jun 11, 2024
Merged

Fix broken enumerateSubstringsInRange:options:usingBlock: implementation #416

merged 2 commits into from
Jun 11, 2024

Conversation

hmelder
Copy link
Contributor

@hmelder hmelder commented Jun 4, 2024

The ICU ubrk API was used wrongly and rendered this method completely useless.

@hmelder hmelder requested a review from rfm as a code owner June 4, 2024 10:17
@hmelder
Copy link
Contributor Author

hmelder commented Jun 4, 2024

#370

@rfm rfm merged commit 3bcb484 into master Jun 11, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rfm rfm Awaiting requested review from rfm rfm is a code owner

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hmelder @rfm