Avoid accessing instance variables in inline functions when compiling with msvc #205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This method takes one argument, so by convention, the name of the variable in the method table should end with a single underscore
|
As this was reviewed in detail in the last pull request I just trust you that this are the same changes. Hopefully we have more luck this time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DPSOperators.hexports various inline functions which access themethodsvariable of theNSGraphicsContextclass. This will result in accessing instance variables across module boundaries if these functions are used in external libraries.Accessing instance variables across module boundaries is not supported when building on Windows using the Visual Studio toolchain.
This patch adds a
methodsfunction onNSGraphicsContextwhich returns the variable, and reworks the inline functions to use themethodsfunction instead of directly accessing the variable.Re-submit of !177