Implement the GlobalAlloc trait, upgrade to nightly-2018-04-15 #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SimonSapin
referenced
this pull request
in servo/servo
Apr 15, 2018
SimonSapin
referenced
this pull request
in servo/servo
Apr 15, 2018
bors-servo
referenced
this pull request
in servo/servo
Apr 15, 2018
Update jemallocator, fix for nightly-2018-04-15 CC https://github.com/alexcrichton/jemallocator/pull/40, rust-lang/rust#49669 <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20640) <!-- Reviewable:end -->
SimonSapin
referenced
this pull request
in servo/servo
Apr 15, 2018
CC https://github.com/alexcrichton/jemallocator/pull/40, rust-lang/rust#49669 The new version of jemallocator requires a more recent jemalloc which doesn’t build on our current Android toolchain. Rather than figuring that out, duplicate ~70 lines from jemallocator and use the older jemalloc-sys directly.
SimonSapin
referenced
this pull request
in servo/servo
Apr 15, 2018
CC https://github.com/alexcrichton/jemallocator/pull/40, rust-lang/rust#49669 The new version of jemallocator requires a more recent jemalloc which doesn’t build on our current Android toolchain. Rather than figuring that out, duplicate ~70 lines from jemallocator and use the older jemalloc-sys directly.
SimonSapin
referenced
this pull request
in servo/servo
Apr 15, 2018
CC https://github.com/alexcrichton/jemallocator/pull/40, rust-lang/rust#49669 The new version of jemallocator requires a more recent jemalloc which doesn’t build on our current Android toolchain. Rather than figuring that out, duplicate ~70 lines from jemallocator and use the older jemalloc-sys directly.
SimonSapin
referenced
this pull request
in servo/servo
Apr 15, 2018
CC https://github.com/alexcrichton/jemallocator/pull/40, rust-lang/rust#49669 The new version of jemallocator requires a more recent jemalloc which doesn’t build on our current Android toolchain. Rather than figuring that out, duplicate ~70 lines from jemallocator and use the older jemalloc-sys directly.
SimonSapin
referenced
this pull request
in servo/servo
Apr 16, 2018
CC https://github.com/alexcrichton/jemallocator/pull/40, rust-lang/rust#49669 The new version of jemallocator requires a more recent jemalloc https://github.com/alexcrichton/jemallocator/pull/34 which doesn’t build on our current Android toolchain jemalloc/jemalloc#1175. To avoid blocking on figuring that out, duplicate ~70 lines from jemallocator and use the older jemalloc-sys directly.
bors-servo
referenced
this pull request
in servo/servo
Apr 16, 2018
Fork the jemallocator crate, fix for nightly-2018-04-15 CC https://github.com/alexcrichton/jemallocator/pull/40, rust-lang/rust#49669 The new version of jemallocator requires a more recent jemalloc https://github.com/alexcrichton/jemallocator/pull/34 which doesn’t build on our current Android toolchain jemalloc/jemalloc#1175. To avoid blocking on figuring that out, duplicate ~70 lines from jemallocator and use the older jemalloc-sys directly. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20641) <!-- Reviewable:end -->
Moggers
referenced
this pull request
in Moggers/servo
Jun 13, 2018
CC https://github.com/alexcrichton/jemallocator/pull/40, rust-lang/rust#49669 The new version of jemallocator requires a more recent jemalloc https://github.com/alexcrichton/jemallocator/pull/34 which doesn’t build on our current Android toolchain jemalloc/jemalloc#1175. To avoid blocking on figuring that out, duplicate ~70 lines from jemallocator and use the older jemalloc-sys directly.
BusyJay
pushed a commit
to BusyJay/jemallocator
that referenced
this pull request
Sep 29, 2022
This works around the mismatch between the GNU target and rustc target. Fixes gnzlbg#36 Signed-off-by: Amanieu d'Antras <amanieu@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CC rust-lang/rust#49669