Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add optional programmatic configuration of the DNS provider #1232

Closed
wants to merge 1 commit into from

Conversation

remilapeyre
Copy link
Contributor

In remilapeyre/vault-acme#19 we would like to be able to use instantiate the same provider multiple times with a different configuration. We could use os.Setenv() to change the environment variables before doing this but it is cumbersome and would require to have a Mutex to avoid race conditions.

This patch add a new config parameters where the values for the configuration is first looked into before looking in the environment variables. Callers that only want to use the environment variables can set this parameter to nil and the old behaviour of looking in the environment variables will be kept.

@ldez ldez self-requested a review August 18, 2020 23:00
@ldez
Copy link
Member

ldez commented Aug 18, 2020

Same topic as #605

The env vars are not really configurable in the way that your thinking: some providers are more complex to handle configuration than env vars inside lego.

Your approach can works for some providers but it's not a valid global approach.

@ldez ldez added the declined label Aug 18, 2020
@ldez
Copy link
Member

ldez commented Aug 18, 2020

I would propose you to open an issue to explain your use case and be able to discuss around this topic.

As I explain in my previous message, this PR, even it the approach is interesting, can not be merge because it's not a valid global approach.

Thanks anyway.

@ldez ldez closed this Aug 18, 2020
@ldez ldez mentioned this pull request Feb 9, 2024
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants