Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: update Designate documentation #1465

Merged
merged 4 commits into from
Sep 20, 2023
Merged

doc: update Designate documentation #1465

merged 4 commits into from
Sep 20, 2023

Conversation

namsral
Copy link
Contributor

@namsral namsral commented Aug 17, 2021

Added public Designate provider Fuga Cloud.

@ldez ldez self-requested a review August 17, 2021 14:21
@ldez
Copy link
Member

ldez commented Aug 17, 2021 •
edited
Loading

Hello,

You have edited a generated file.

I'm not sure how to see/interpret your change, please give me more explanation

@namsral
Copy link
Contributor Author

namsral commented Aug 17, 2021

Sorry, meant to make changes to providers/dns/designate/designate.toml instead.

@ldez
Copy link
Member

ldez commented Aug 17, 2021

Maybe I was not clear: your PR feels like an advertisement for Fuga Cloud.
lego is not a place to reference cloud provider features.

Maybe I'm wrong, then please give me more information about your goal and your expectation with this PR.

@namsral
Copy link
Contributor Author

namsral commented Aug 18, 2021

I find it convenient that lego has a list of supported DNS providers. But because not all cloud providers have a custom DNS API I though it convenient for DNS providers with more standardised DNS API to also be listed as custom APIs are now very dominant.

If it makes any difference I can refactor the PR to include other "standardised" DNS providers like Netnod.se which supports RFC2136.

@ldez ldez added this to the v4.14 milestone Jul 27, 2023
@ldez ldez force-pushed the feature/add-designate-providers branch from 0cedcfe to 36f02a9 Compare July 27, 2023 11:51
@ldez ldez enabled auto-merge (squash) July 27, 2023 11:51
@ldez ldez disabled auto-merge July 27, 2023 11:52
@ldez ldez changed the title Update Designate documentation doc: update Designate documentation Jul 27, 2023
@ldez ldez enabled auto-merge (squash) July 27, 2023 11:52
@ldez ldez modified the milestones: v4.14, v4.15 Sep 20, 2023
Lars Wiegman and others added 4 commits September 20, 2023 21:32
@ldez ldez force-pushed the feature/add-designate-providers branch from 36f02a9 to b6497b6 Compare September 20, 2023 19:32
@ldez ldez merged commit d0aa6b3 into go-acme:master Sep 20, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ldez ldez ldez approved these changes

Assignees
No one assigned
Labels
area/documentation enhancement
Milestone
v4.15
Development

Successfully merging this pull request may close these issues.
2 participants
@namsral @ldez