route53: Allow static credentials to be supplied #1746
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ldez sorry for the delay, should be ready to review now! |
|
@ldez looks like the failed tests are unrelated to route53 (unless they are depending on route53 for some reason that I don't know about. |
ldez
changed the title
This is incremental progress to implementing #1736, the first part being porting over certain providers (specifically route53 and lightsail) to use static credentials not derived from the environment. This specifically adds support for the static chain where an access key ID, secret access key, and (optionally) a session token can be supplied manually.
|
Sorry for the time, I had to manage personal constraints that have slowed me down for a few months. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is incremental progress to implementing #1736, the first part being porting over certain providers (specifically route53 and lightsail) to use static credentials not derived from the environment.
This specifically adds support for the static chain where an access key ID, secret access key, and (optionally) a session token can be supplied manually.