chore: replace GetRecord by GetChallengeInfo #1863
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ldez
force-pushed
the
feat/challenge-info
branch
from
05d8a8d to
2aa38f9
Compare
dmke
reviewed
Mar 3, 2023
ldez
force-pushed
the
feat/challenge-info
branch
from
2aa38f9 to
cbadbfa
Compare
ldez
force-pushed
the
feat/challenge-info
branch
from
cbadbfa to
1a92f82
Compare
dmke
requested changes
Mar 6, 2023
Co-authored-by: Dominik Menke <git@dmke.org>
|
@dmke prepare your body my next PR will be a special 😸 |
dmke
approved these changes
Mar 7, 2023
2 tasks
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The name of the function
GetRecordwas ambiguous because it didn't return a record, but just information about the challenge (FQDN and token value).I also do that because of a bug with the
acme-dnsprovider: #1861The provider
acme-dnsmust not use the FQDN produced by following CNAMEs because the CNAMEs are handled internally by the provider.Fixes #1861