Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DNS provider for hosting.nl #1967

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Conversation

ldez
Copy link
Member

@ldez ldez commented Jul 23, 2023

  • add a description to your PR
  • have a homogeneous design with the other providers
  • add tests (units)
  • add tests ("live")
  • add a provider descriptor
  • generate CLI help, documentation, and readme.
  • be able to do: (and put the output of this command to a comment in your PR)
    make build
    rm -rf .lego
    
    HOSTINGNL_API_KEY="xxxxxxxxxxxxxxxxxxxxx" \
    ./dist/lego -m your@email.com --dns hostingnl -d *.example.com -d example.com -s https://acme-staging-v02.api.letsencrypt.org/directory run
    Note the wildcard domain is important.
  • pass the linter
  • do go mod tidy

Ping @arnovdk, can you run the command (with your domain, email, and credentials)?

How to test this PR?
  1. You need Go
  2. Checkout the PR:
    git clone https://github.com/ldez/lego.git
    cd lego
    git checkout feat/hostingnl
  3. Compile lego:
    • if you have make: make build
    • if you don't make make: go build ./cmd/lego -o dist/lego
  4. Run the following command with your own information (email, domain, credentials):
    HOSTINGNL_API_KEY="xxxxxxxxxxxxxxxxxxxxx" \
    ./dist/lego -m your@email.com --dns hostingnl -d *.example.com -d example.com -s https://acme-staging-v02.api.letsencrypt.org/directory run
    The wildcard domain is important
  5. Before each run of the command, you should clean your local environment:
    rm -rf .lego

Closes #1598

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

Support for provider: hosting.nl (SQR.nl)
1 participant