Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: fills LEGO_CERT_PFX_PATH and LEGO_CERT_PEM_PATH only when needed #2160

Merged
merged 2 commits into from
Apr 16, 2024
Merged

feat: fills LEGO_CERT_PFX_PATH and LEGO_CERT_PEM_PATH only when needed #2160

merged 2 commits into from
Apr 16, 2024

Conversation

ldez
Copy link
Member

@ldez ldez commented Apr 16, 2024

Fixes #2158

@ldez ldez added this to the v4.17 milestone Apr 16, 2024
@ldez ldez requested a review from dmke April 16, 2024 11:08
dmke
dmke approved these changes Apr 16, 2024
View reviewed changes
Copy link
Member

@dmke dmke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should update the documentation accordingly (docs/content/usage/cli/{Obtain,Renew}-a-Certificate.md).

@ldez ldez merged commit d60c335 into go-acme:master Apr 16, 2024
4 checks passed
@ldez ldez deleted the feat/pfx-pem-env-vars branch April 16, 2024 21:11
@ldez ldez mentioned this pull request Jul 25, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmke dmke dmke approved these changes

Assignees
No one assigned
Labels
area/cli enhancement
Milestone
v4.17
Development

Successfully merging this pull request may close these issues.

Missing and misleading hook environment variables
2 participants
@ldez @dmke