Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ovh: add OAuth2 authentication #2173

Merged
merged 11 commits into from
May 6, 2024

Conversation

Idix
Copy link
Contributor

@Idix Idix commented May 5, 2024

Description

The latest go-ovh version allows authentication using OAuth2 client_id and client_secret. Which in turn can be provisioned using the OVH terraform provider thus enabling everything to be configured as code.

Note

I'm not usually writing code in Go so I'm not sure if everything is idiomatic. Please advice if something needs to be changed to be more in line with the rest of the code.

@ldez ldez changed the title Add OAuth2 authentication for OVH provider ovh: add OAuth2 authentication May 5, 2024
@ldez ldez self-requested a review May 5, 2024 19:43
@ldez ldez added this to the v4.17 milestone May 5, 2024
Copy link
Member

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ldez ldez merged commit acd3382 into go-acme:master May 6, 2024
4 checks passed
@Idix
Copy link
Contributor Author

Idix commented May 6, 2024

I see you did all the hard work, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants