alidns: migrate to SDK v2 #2558
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
But there is no link inside the readme about this SDK v2.
There is a link inside the "About" section to an org: https://github.com/aliyun/alibabacloud-sdk
I found 2 repositories:
The 2 repositories contain the same module:
github.com/alibabacloud-go/alidns-20150109/v4The code seems identical.
The main file is
client/client.go: a 2.03 MB file with more than 67k LOC, too large to be displayed inside GitHub.There is a light migration guide, but the SDK APIs are closed.
The size of the lib inside the GOCACHE is reduced:
SDK v1:
SDK v2:
Total: ~2.83 MiB
And it decreases the binary by ~5MB.