Issue 90 unittest #95
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wip-github-action
Rename codecov to codecov.yml Update codecov.yml Update codecov.yml wip-github-action wip-github-action remove tests under internal package 从internal目录下移除测试项目，因为在此包里的单测运行时会依赖外部环境(model.init()方法导致）； issue 90; 修改go ver为1.17 remove test.yml make a failed case Revert "make a failed case" This reverts commit 9f3a7dd. t#
Codecov Report
@@ Coverage Diff @@
## v1.5.0-feat-app-refactor #95 +/- ##
===========================================================
Coverage ? 42.23%
===========================================================
Files ? 4
Lines ? 161
Branches ? 0
===========================================================
Hits ? 68
Misses ? 91
Partials ? 2 Continue to review full report at Codecov.
|
colynn
reviewed
Mar 7, 2022
There was a problem hiding this comment.
internal/core/notification/notify_test.go 是无效的test吗，为什么需要移除 ＠fanhousanbu
原因：#95 (comment) |
是否可以将model的init 独立为db的pkg， 将init 转为具体的函数调用 |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which changes (Bug/Feature):
Fixes #90 github action 集成单测
Special notes for reviewers: