This repository has been archived by the owner on Feb 16, 2022. It is now read-only.
Add more MFA supports (for v5) #157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lambdalisue
force-pushed
the
support-mfa
branch
from
bf93189
to
be9a524
Compare
lambdalisue
force-pushed
the
support-mfa
branch
from
fac42e1
to
6d0e37c
Compare
Closed
|
@alexkappa @lambdalisue came here looking for this! Anything I can do to help move this along please let me know 👍🏻 |
|
@alexkappa I'm sorry to rush you but please let me know what I should do to get this PR merged. |
|
@alexkappa @paddycarey what can we do to get things like this reviewed and merged in a reasonable timeframe? I'm willing to offer my time and efforts to help in any way possible. |
|
While #110 is closed, this PR is no more duplicated. Could anyone remove the |
|
@alexkappa please assign for review. Thanks. |
|
@yvovandoorn here is a useful PR that could use review. Thanks! |
|
This looks good to merge. |
|
Thanks a lot 🎉 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First of all, thanks for the great library 🎉
I needed to manipulate MFA things through the management APIs thus I've added some endpoints.
There is a PR for that (#110) but it seems staled so I've created a new one with some improvements so please check it (to be honest, I didn't notice that PR when I was writing code. I just noticed that when I tried to make a PR.)
Let me know If I should apply changes to that PR or need more extra works.