Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use whole IPV6 #50

Closed
wants to merge 4 commits into from
Closed

Use whole IPV6 #50

wants to merge 4 commits into from

Conversation

klaidliadon
Copy link
Contributor

No description provided.

@pkieltyka
Copy link
Member

can we fix tests?

VojtechVitek
VojtechVitek approved these changes Nov 28, 2024
View reviewed changes
Copy link
Contributor

@VojtechVitek VojtechVitek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this mean we'd rate-limit by whole IPv6 addresses instead of the /64 prefix?

LGTM

httprate.go
@@ -164,5 +164,5 @@ func canonicalizeIP(ip string) string {
return ip
}

return ipv6.Mask(net.CIDRMask(64, 128)).String()
return ipv6.String()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you update the comment at line :141 pls?

@klaidliadon klaidliadon deleted the patch-1 branch November 28, 2024 16:18
@VojtechVitek
Copy link
Contributor

We decided to stay at /64 prefix given:

| 5G/LTE        | /64, /56                  | /64 for devices; /56 for tethering |
| Starlink      | /56, /48                  | /56 residential; /48 enterprise    |
| Fixed ISPs    | /56, /48, /64             | /56 typical for home users         |

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VojtechVitek VojtechVitek VojtechVitek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@klaidliadon @pkieltyka @VojtechVitek