Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handle occasional occurence of double run on daily job #159

Merged
merged 5 commits into from
Apr 13, 2021

Conversation

JohnRoesler
Copy link
Contributor

What does this do?

we see an occasional instance of a daily job running twice within a second. this seems to be due to the job running too fast and starting a fraction of a second early such that it runs during the 1 second window before it should. this fix handles that case for daily jobs as those only run once at a given even hour/min/sec time.

Which issue(s) does this PR fix/relate to?

#52 (comment)

List any changes that modify/break current functionality

Have you included tests for your changes?

Did you document any new/modified functionality?

  • Updated example_test.go
  • Updated README.md

Notes

scheduler.go Outdated Show resolved Hide resolved
Streppel
Streppel previously approved these changes Apr 13, 2021
Co-authored-by: streppel <streppels@gmail.com>
@JohnRoesler JohnRoesler merged commit f90a556 into go-co-op:master Apr 13, 2021
@JohnRoesler JohnRoesler deleted the double-runs-daily branch April 13, 2021 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants