catch time.AfterFunc firing early per wall clock time #214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+199
to
+205
| if !next.dateTime.IsZero() { | ||
| for { | ||
| if time.Now().Unix() >= next.dateTime.Unix() { | ||
| break | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
Hi, it seems that another solution may be just rounding all time/durartions up to second precision (omitting milliseconds at all). As cron minimal resolution is minute, such rounding should not harm any library users.
Not sure, just a proposal.
There was a problem hiding this comment.
Hey @artemgavrilov - that's true if seconds was the lowest resolution, but we do offer millisecond precision through the use of the time.Duration scheduling, e.g. scheduler.Every("100ms")
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this do?
catches the case where a job expected to run at a specific wall clock time fires early due to wall and monotonic clocks being slightly out of sync - most commonly occurring in docker.
Which issue(s) does this PR fix/relate to?
#52 #132
List any changes that modify/break current functionality
Have you included tests for your changes?
Did you document any new/modified functionality?
example_test.goREADME.mdNotes