issue-740: ascending time function #744
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JohnRoesler
reviewed
Jun 22, 2024
util.go
Outdated
| return atTimesDate, nil | ||
| } | ||
|
|
||
| func AscendingTime(a, b time.Time) int { |
There was a problem hiding this comment.
This shouldn't need to be exported
There was a problem hiding this comment.
good catch, I didn't realize that it was all in the same package. Pushed 👍
JohnRoesler
approved these changes
Jun 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this do?
Which issue(s) does this PR fix/relate to?
Followup optional comments on #740 and including test for out of order job
atTimeswhich were missing.List any changes that modify/break current functionality
Have you included tests for your changes?
Yes
Did you document any new/modified functionality?
example_test.goREADME.mdNotes