Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

service/dap: set seq field in responses #2245

Open
polinasok opened this issue Dec 2, 2020 · 0 comments
Open

service/dap: set seq field in responses #2245

polinasok opened this issue Dec 2, 2020 · 0 comments

Comments

@polinasok
Copy link
Collaborator

When studying vscode-go logs, I saw that seq was only used for requests and request_seq was used for responses while seq always stayed 0. For example:

To client: {"seq":0,"type":"response","request_seq":1,"command":"initialize","success":true,"body":{"supportsConditionalBreakpoints":true,"supportsConfigurationDoneRequest":true,"supportsSetVariable":true}}
To client: {"seq":0,"type":"event","event":"output","body":{"category":"stdout","output":"API server listening at: 127.0.0.1:38993\n"}}
To client: {"seq":0,"type":"event","event":"initialized"}
To client: {"seq":0,"type":"response","request_seq":2,"command":"launch","success":true}

It turns out that this is an artifact of a bug in the parent code (microsoft/vscode-debugadapter-node#239) and in fact increasing seq numbrers are used. It doesn't seem like this is hurting anything, so this is likely just for bookkeeping on our end.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants