To-client sequence numbers are misleadingly logged as 0

[polinasok]

I noticed this when debugging vscode-go, which inherits from vscode-debugadapter and relies on much of the code in LoggingDebugSession, etc.

Here is a stack trace for logging the following response:

To client: {"seq":0,"type":"response","request_seq":2,"command":"launch","success":true}

• ProtocolServer::_send # sets message.seq = this._sequence++ before sending
• ProtocolServer::sendResponse
• LoggingDebugSession::SendResponse # logs the message with "seq":0 before calling the above functions

Same thing happens with events.

This is quite unfortunate because logging is an important for implementers who want to studying the interactions between the client and the adapter.

Is there any downside to moving logging after the raw send when the response object is populated with the right seq number?