Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

proc: support childless compile units in loadDebugInfoMaps #1574

Merged
merged 1 commit into from
Jun 11, 2019
Merged

proc: support childless compile units in loadDebugInfoMaps #1574

merged 1 commit into from
Jun 11, 2019

Conversation

aarzilli
Copy link
Member

@aarzilli aarzilli commented Jun 6, 2019 •
edited
Loading 

proc: support childless compile units in loadDebugInfoMaps

Childless compile units would confuse loadDebugInfoMaps.
No test because I don't know what causes go to invoke GNU As in such a
way that it produces a childless compile unit.

Fixes #1572

@aarzilli
proc: support childless compile units in loadDebugInfoMaps
940e8c6 
Childless compile units would confuse loadDebugInfoMaps.
No test because I don't know what causes go to invoke GNU As in such a
way that it produces a childless compile unit.

Fixes go-delve#1572
@aarzilli aarzilli mentioned this pull request Jun 11, 2019
Closed
derekparker
derekparker approved these changes Jun 11, 2019
View reviewed changes
Copy link
Member

@derekparker derekparker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@derekparker derekparker merged commit cce3770 into go-delve:master Jun 11, 2019
cgxxv pushed a commit to cgxxv/delve that referenced this pull request Mar 25, 2022
@aarzilli @derekparker
proc: support childless compile units in loadDebugInfoMaps (go-delve#…
1bf5114 
…1574)

Childless compile units would confuse loadDebugInfoMaps.
No test because I don't know what causes go to invoke GNU As in such a
way that it produces a childless compile unit.

Fixes go-delve#1572
abner-chenc pushed a commit to loongson/delve that referenced this pull request Mar 1, 2024
@aarzilli @abner-chenc
proc: support childless compile units in loadDebugInfoMaps (go-delve#…
e8479d8 
…1574)

Childless compile units would confuse loadDebugInfoMaps.
No test because I don't know what causes go to invoke GNU As in such a
way that it produces a childless compile unit.

Fixes go-delve#1572
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@derekparker derekparker derekparker approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aarzilli @derekparker @FrankDuan