Fix starlark map iteration for maps > 64 entries #1699
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I discovered that
dlv
wasn't correctly iterating over maps larger than 64 elements.Ref: https://github.com/go-delve/delve/blob/master/Documentation/cli/expr.md#elements-limit
This was because in
mapVariableAsStarlarkValueIterator.Next()
, we are iterating in 2s, but we are not resuming/2
for the next offset.