dap: support suspendDebuggee in multi-client mode #3003
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Actually give me a moment to revise something before reviewing. |
polinasok
force-pushed
the
remoteSuspend
branch
2 times, most recently
from
6751910
to
ed1827f
Compare
aarzilli
reviewed
May 20, 2022
| if request.Arguments.SuspendDebuggee { | ||
| status = "suspended" | ||
| s.changeStateMu.Lock() | ||
| defer s.changeStateMu.Unlock() |
There was a problem hiding this comment.
This defer gets executed when the function exits. Is this really the intended scope? There's a lot of code after this if/else that will get executed either with or without holding the mutex.
|
Going to close for now due to inactivity. Please reopen if this is still necessary / planned to be worked on. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upstream dependency at microsoft/vscode#134412 is in, so we can now provide this in our DA to give people more disconnect options.
Updates #2772