Skip to content
This repository has been archived by the owner on Oct 13, 2021. It is now read-only.

Improve README #8

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Improve README #8

wants to merge 1 commit into from

Conversation

lokeshh
Copy link

@lokeshh lokeshh commented Oct 25, 2017

Remove useless $

mariida
mariida reviewed Oct 25, 2017
View reviewed changes
Copy link

@mariida mariida left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SOME THING FOUN ERROR

@lokeshh lokeshh closed this Oct 25, 2017
@lokeshh lokeshh reopened this Oct 25, 2017
@vcaesar
Copy link
Member

vcaesar commented Oct 26, 2017 •
edited
Loading

Thank you for your pr, reserve one's opinion, please see dep , gin and bee's README.md. $ Is the normal user's prompt.

vcaesar
vcaesar suggested changes Oct 26, 2017
View reviewed changes
Copy link
Member

@vcaesar vcaesar left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

$ Is the normal user's prompt.

@vcaesar vcaesar modified the milestones: v1.0.0, v0.10.0 Oct 26, 2017
@vcaesar vcaesar closed this Oct 26, 2017
@lokeshh
Copy link
Author

lokeshh commented Oct 26, 2017

@vcaesar I agree but it makes things hard to copy paste. Further for the first two commands you don't have $, hence it isn't consistent.

@vcaesar
Copy link
Member

vcaesar commented Oct 26, 2017

@lokeshh Ok, let me think about it.

@vcaesar vcaesar reopened this Oct 26, 2017
@vcaesar vcaesar modified the milestones: v0.10.0, v0.20.0 Nov 21, 2017
@CLAassistant
Copy link

CLAassistant commented Aug 8, 2019 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mariida mariida mariida left review comments

@vcaesar vcaesar vcaesar requested changes

@bettylily bettylily bettylily approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.20.0
Development

Successfully merging this pull request may close these issues.
5 participants
@lokeshh @vcaesar @CLAassistant @mariida @bettylily