Skip to content
This repository has been archived by the owner on Oct 13, 2021. It is now read-only.

align the way to calculate hash #94

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

Ksloveyuan
Copy link

The pull request will be closed without any reasons if it does not satisfy any of following requirements:

  1. Make sure you are targeting the master branch, pull requests on release branches are only allowed for bug fixes.
  2. Please read contributing guidelines: CONTRIBUTING
  3. Describe what your pull request does and which issue you're targeting (if any and Please use English)
  4. ... if it is not related to any particular issues, explain why we should not reject your pull request.
  5. The Commits must use English, must be test and No useless submissions.

You MUST delete the content above including this line before posting, otherwise your pull request will be invalid.

Description

The hash is used in segment.go line 260 to calculate shard index, rigth?

As calculate hash by both docid and content, if the content changes a bit then update the same docid's index, it will be highly possible assigned to another shard, so that there will be duplicated search result with same docid, which is not expected.

@CLAassistant
Copy link

CLAassistant commented Aug 8, 2019

CLA assistant check
All committers have signed the CLA.

Jeremy, Liu added 2 commits August 8, 2019 21:09
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants