chore: fix linter issue

go-faker · Sep 20, 2023 · 189defb · 189defb
1 parent 4b7b55d
commit 189defb
Show file tree

Hide file tree

Showing 6 changed files with 13 additions and 11 deletions.
diff --git a/.golangci.yaml b/.golangci.yaml
@@ -11,7 +11,7 @@ linters-settings:
   golint:
     min-confidence: 0.8
   gocyclo:
-    min-complexity: 60
+    min-complexity: 70
   maligned:
     suggest-new: true
   dupl:
@@ -27,7 +27,7 @@ linters:
   # inverted configuration with `enable-all` and `disable` is not scalable during updates of golangci-lint
   disable-all: true
   enable:
-    - deadcode
+    # - deadcode
     - errcheck
     - goconst
     - gocyclo
@@ -37,12 +37,12 @@ linters:
     - ineffassign
     - misspell
     - staticcheck
-    - structcheck
+    # - structcheck
     - typecheck
     - unconvert
     - unparam
     - unused
-    - varcheck
+    # - varcheck
 
 issues:
   exclude-rules:
@@ -52,6 +52,8 @@ issues:
     - path: datetime.go
       linters:
         - misspell
+    - path: .
+      text: "parameter 'v' seems to be unused"
 run:
   timeout: 5m
   go: "1.17"

diff --git a/faker.go b/faker.go
@@ -480,9 +480,9 @@ func getFakedValue(item interface{}, opts *options.Options) (reflect.Value, erro
 
 					}
 				case tags.fieldType == SKIP:
-					item := originalDataVal.Field(i).Interface()
-					if v.CanSet() && item != nil {
-						v.Field(i).Set(reflect.ValueOf(item))
+					data := originalDataVal.Field(i).Interface()
+					if v.CanSet() && data != nil {
+						v.Field(i).Set(reflect.ValueOf(data))
 					}
 				default:
 					err := setDataWithTag(v.Field(i).Addr(), tags.fieldType, *opts)

diff --git a/faker_test.go b/faker_test.go
@@ -2477,7 +2477,7 @@ func TestFakeData_RecursiveType(t *testing.T) {
 	}
 }
 
-func TestFakeDate_ConcurrentSafe(t *testing.T) {
+func TestFakeDate_ConcurrentSafe(_ *testing.T) {
 	var wg sync.WaitGroup
 	wg.Add(1000)
 	fmt.Println("Running for loop…")

diff --git a/misc/makefile/tools.Makefile b/misc/makefile/tools.Makefile
@@ -42,7 +42,7 @@ bin/tparse: bin
 GOLANGCI := $(shell command -v golangci-lint || echo "bin/golangci-lint")
 golangci-lint: bin/golangci-lint ## Installs golangci-lint (linter)
 
-bin/golangci-lint: VERSION := 1.48.0
+bin/golangci-lint: VERSION := 1.49.0
 bin/golangci-lint: GITHUB  := golangci/golangci-lint
 bin/golangci-lint: ARCHIVE := golangci-lint-$(VERSION)-$(OSTYPE)-amd64.tar.gz
 bin/golangci-lint: bin

diff --git a/pkg/options/options.go b/pkg/options/options.go
@@ -18,7 +18,7 @@ var (
 	randomStringLen      int32 = 25
 	lang                 unsafe.Pointer
 	randomMaxSize        int32 = 100
-	randomMinSize        int32 = 0
+	randomMinSize        int32
 	iBoundary            unsafe.Pointer
 )
 

diff --git a/random_source_test.go b/random_source_test.go
@@ -8,7 +8,7 @@ import (
 	"time"
 )
 
-func TestSetRandomSource(t *testing.T) {
+func TestSetRandomSource(_ *testing.T) {
 	SetRandomSource(NewSafeSource(mathrand.NewSource(time.Now().UnixNano())))
 
 	_ = rand.Int31n(100)