Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improve null and bool decoding #18

Merged
merged 4 commits into from
Jan 14, 2022

Conversation

tdakkota
Copy link
Member

@tdakkota tdakkota commented Jan 14, 2022

Valid/bools.json-12           2.14µs ± 2%    1.66µs ± 0%  -22.57%  (p=0.000 n=15+14)
Valid/canada.json-12          3.95ms ± 4%    3.94ms ± 2%     ~     (p=0.878 n=15+11)
Valid/citm_catalog.json-12    1.95ms ± 3%    1.85ms ± 4%   -4.69%  (p=0.000 n=15+15)
Valid/floats.json-12          2.90µs ± 1%    2.96µs ± 1%   +1.99%  (p=0.000 n=15+15)
Valid/large.json-12           49.3µs ± 3%    45.6µs ± 3%   -7.40%  (p=0.000 n=13+14)
Valid/medium.json-12          3.78µs ± 3%    3.58µs ± 3%   -5.27%  (p=0.000 n=15+15)
Valid/nulls.json-12           1.94µs ± 0%    1.51µs ± 0%  -21.91%  (p=0.000 n=13+13)
Valid/otel_ex_1.json-12        607ns ± 2%     652ns ± 7%   +7.52%  (p=0.000 n=15+15)
Valid/small.json-12            353ns ± 3%     357ns ± 1%   +1.15%  (p=0.012 n=14+12)
Valid/twitter.json-12          892µs ± 6%     845µs ± 3%   -5.26%  (p=0.000 n=15+15)

@codecov
Copy link

codecov bot commented Jan 14, 2022

Codecov Report

Merging #18 (cbdf6d5) into main (8242f8a) will decrease coverage by 0.13%.
The diff coverage is 95.16%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #18      +/-   ##
==========================================
- Coverage   99.50%   99.36%   -0.14%     
==========================================
  Files          29       29              
  Lines        2031     2057      +26     
==========================================
+ Hits         2021     2044      +23     
- Misses          8       10       +2     
- Partials        2        3       +1     
Impacted Files Coverage Δ
dec.go 98.35% <82.35%> (-1.65%) ⬇️
dec_skip.go 98.44% <100.00%> (+0.05%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8242f8a...cbdf6d5. Read the comment docs.

Copy link
Member

@ernado ernado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fuzz: elapsed: 29m27s, execs: 83852895 (46575/sec), new interesting: 0 (total: 405)
fuzz: elapsed: 29m30s, execs: 83999235 (48746/sec), new interesting: 0 (total: 405)
fuzz: elapsed: 29m33s, execs: 84162976 (54622/sec), new interesting: 0 (total: 405)
fuzz: elapsed: 29m36s, execs: 84289502 (42175/sec), new interesting: 0 (total: 405)
fuzz: elapsed: 29m39s, execs: 84438027 (49501/sec), new interesting: 0 (total: 405)
fuzz: elapsed: 29m42s, execs: 84587485 (49810/sec), new interesting: 0 (total: 405)
fuzz: elapsed: 29m45s, execs: 84722561 (45030/sec), new interesting: 0 (total: 405)
fuzz: elapsed: 29m48s, execs: 84867400 (48283/sec), new interesting: 0 (total: 405)
fuzz: elapsed: 29m51s, execs: 85002095 (44906/sec), new interesting: 0 (total: 405)
fuzz: elapsed: 29m54s, execs: 85138442 (45448/sec), new interesting: 0 (total: 405)

@ernado ernado marked this pull request as ready for review January 14, 2022 12:25
@ernado ernado merged commit 9ff8bd0 into go-faster:main Jan 14, 2022
@tdakkota tdakkota deleted the feat/faster-null branch January 14, 2022 12:34
@tdakkota tdakkota mentioned this pull request Jan 14, 2022
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants