Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add options for server #2

Merged
merged 2 commits into from
Aug 16, 2021
Merged

Add options for server #2

merged 2 commits into from
Aug 16, 2021

Conversation

rentziass
Copy link
Contributor

@rentziass rentziass commented Aug 16, 2021

This would give a user the possibility of creating a new server and fully rely on the package sensible defaults, while giving the power the change what they want to change. And that comes with the benefit that adding more fields or options for a Server doesn't necessarily add more complexity or checks to New itself

A few examples of how this would look from a user perspective:

flexmetrics.New()
flexmetrics.New(flexmetrics.WithAddr(os.Getenv("MY_OWN_ENV_VAR"))
flexmetrics.New(flexmetrics.WithServer(myCustomerOPProprietaryServer))

@ladydascalie ladydascalie merged commit 8f35c00 into develop Aug 16, 2021
@ladydascalie ladydascalie deleted the options branch August 16, 2021 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants