Skip to content

Beta #219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
pchampio merged 12 commits into from
Sep 3, 2019
Merged

Beta #219

pchampio merged 12 commits into from
Sep 3, 2019

Conversation

@pchampio
Copy link
Member

@pchampio pchampio commented Aug 2, 2019 •
edited
Loading

@pchampio pchampio force-pushed the beta branch 10 times, most recently from be33505 to 5a56184 Compare August 4, 2019 19:12
@pchampio
fix: remove initial WaitEvent
0e810c5 
now that we have implemented the proper event loop.
Delete the first WaitEvent
@pchampio
Copy link
Member Author

pchampio commented Aug 13, 2019 •
edited
Loading

The initial glfw.WaitEvents()(the one before the event loop) has been removed.
I didn't liked the workaround and it might be the causes to #230.
The following warning can still occur:

[ERROR:flutter/lib/ui/ui_dart_state.cc(148)] Unhandled Exception: 'package:flutter/src/gestures/converter.dart': Failed assertion: line 359 pos 20: '_pointers.containsKey(datum.device)': is not true.
#0      _AssertionError._doThrowNew (dart:core-patch/errors_patch.dart:40:39)
#1      _AssertionError._throwNew (dart:core-patch/errors_patch.dart:36:5)
#2      PointerEventConverter.expand (package:flutter/src/gestures/converter.dart:359:20)
#3      _SyncIterator.moveNext (dart:core-patch/core_patch.dart:144:12)
#4      ListQueue.addAll (dart:collection/queue.dart:655:25)
#5      _WidgetsFlutterBinding&BindingBase&GestureBinding._handlePointerDataPacket (package:flutter/src/gestures/binding.dart:84:27)
#6      _rootRunUnary (dart:async/zone.dart:1136:13)
#7      _CustomZone.runUnary (dart:async/zone.dart:1029:19)
#8      _CustomZone.runUnaryGuarded (dart:async/zone.dart:931:7)
#9      _invoke1 (dart:ui/hooks.dart:252:10)
#10     _dispatchPointerDataPacket (dart:ui/hooks.dart:161:5)

Fixed by: 2c365ea#diff-cfa025f8f8a94cc57e954d7fbd3ceff1R67

@pchampio
Copy link
Member Author

pchampio commented Aug 13, 2019

This Branch is compatible with flutter channel beta.
Asking for review!

@pchampio pchampio requested a review from GeertJohan August 13, 2019 12:51
GeertJohan
GeertJohan reviewed Aug 18, 2019
View reviewed changes
GeertJohan
GeertJohan reviewed Aug 18, 2019
View reviewed changes
GeertJohan
GeertJohan reviewed Aug 18, 2019
View reviewed changes
GeertJohan
GeertJohan reviewed Aug 18, 2019
View reviewed changes
pchampio
pchampio commented Aug 18, 2019
View reviewed changes
pchampio
pchampio commented Aug 18, 2019
View reviewed changes
pchampio
pchampio commented Aug 20, 2019
View reviewed changes
GeertJohan
GeertJohan reviewed Sep 2, 2019
View reviewed changes
event-loop.go Outdated
heap.Init(pq)
return &EventLoop{
priorityqueue: pq,
mainThreadID: embedder.GetCurrentTheradID(),
Copy link
Member

@GeertJohan GeertJohan Sep 2, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo Therad. Also: should we maybe make this function available from an internal package, not as part of the embedder package?

@GeertJohan
Copy link
Member

GeertJohan commented Sep 2, 2019

Failure to compile for windows? #245

@pchampio pchampio self-assigned this Sep 3, 2019
@pchampio pchampio merged commit c52311f into master Sep 3, 2019
@pchampio pchampio deleted the beta branch September 3, 2019 21:34
@pchampio pchampio mentioned this pull request Sep 3, 2019
Closed
@nzlov nzlov mentioned this pull request Sep 5, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@GeertJohan GeertJohan GeertJohan approved these changes

Assignees

@pchampio pchampio

Labels

None yet

Milestone

No milestone

4 participants

@pchampio @GeertJohan @davidmartos96