feat: add ability to disable just the swagger ui #155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dylanhitt
force-pushed
the
feat/disableUI
branch
from
bfcd256 to
124ae24
Compare
|
Isn't it enough to do this ? 
Or do you want to disable the UI and keep the JSON served? |
|
Oops sorry for the force-push (for a typo), don't worry I'll handle it myself once we agree on what to do :) |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
per #154
We should provide a way to disable the UI and also not have the route register. I elected to keep with the
DisableSwagger*vernacular. Which maybe we want to be more specific in the future, maybe a bit more thought out (my bad 😄).Maybe a discussion over the interface is warranted, but for now 🤷
Cheers