Description option : override + default description contains the list of middlewares #275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EwenQuim
commented
Dec 13, 2024
dylanhitt
reviewed
Dec 13, 2024
|
The end goal is to have this default description : 
A user might want the ability to disable or override it. Perhaps providing a route-level option to disable it would be a better solution? |
|
I was more asking about the naming of the function. Why change to Add vs just |
EwenQuim
force-pushed
the
refactor-register-controller
branch
2 times, most recently
from
7ea6109 to
667dae2
Compare
EwenQuim
changed the title
EwenQuim
changed the title
EwenQuim
force-pushed
the
refactor-register-controller
branch
from
cbd1966 to
59f7953
Compare
EwenQuim
force-pushed
the
refactor-register-controller
branch
from
59f7953 to
3c4db6b
Compare
dylanhitt
reviewed
Dec 14, 2024
dylanhitt
approved these changes
Dec 14, 2024
ccoVeille
reviewed
Dec 14, 2024
Co-authored-by: ccoVeille <3875889+ccoVeille@users.noreply.github.com>
Ignaciojeria
pushed a commit
to Ignaciojeria/fuego
that referenced
this pull request
Dec 26, 2024
… of middlewares (go-fuego#275) * Refactored the Description/AddDescription to a clearer system * New more explicit OverrideDescription option * Tests for the description option with middlewares * Make tag order deterministic * Update option.go Co-authored-by: ccoVeille <3875889+ccoVeille@users.noreply.github.com> * Makes overrideDescription private in BaseRoute * Moved the operation ID generation to a method on the BaseRoute struct. * Generate description is in OpenAPI registration, not in mux registration --------- Co-authored-by: ccoVeille <3875889+ccoVeille@users.noreply.github.com>
Ignaciojeria
pushed a commit
to Ignaciojeria/fuego
that referenced
this pull request
Dec 26, 2024
… of middlewares (go-fuego#275) * Refactored the Description/AddDescription to a clearer system * New more explicit OverrideDescription option * Tests for the description option with middlewares * Make tag order deterministic * Update option.go Co-authored-by: ccoVeille <3875889+ccoVeille@users.noreply.github.com> * Makes overrideDescription private in BaseRoute * Moved the operation ID generation to a method on the BaseRoute struct. * Generate description is in OpenAPI registration, not in mux registration --------- Co-authored-by: ccoVeille <3875889+ccoVeille@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.