golangci party #364
Merged
golangci party #364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and add a linter to catch them
And add a linter for avoiding such issues.
The linter is still disabled as they are more errors to fix. But it would require further checks and discussion, this is a good start
Also enable a linter to detect such issues
Apply the reported changes to the codebase. Disable some rules that might be reporting false positives. But it could also be bugs, so it requires manual review and discussion.
EwenQuim
reviewed
Jan 21, 2025
Comment on lines
44
to
51
| func (m DataOrTemplate[T]) Render(c context.Context, w io.Writer) error { | ||
| switch m.Template.(type) { | ||
| switch renderer := m.Template.(type) { | ||
| case CtxRenderer: | ||
| return m.Template.(CtxRenderer).Render(c, w) | ||
| return renderer.Render(c, w) | ||
| case Renderer: | ||
| return m.Template.(Renderer).Render(w) | ||
| return renderer.Render(w) | ||
| default: | ||
| panic("template must be either CtxRenderer or Renderer") |
There was a problem hiding this comment.
OMG I didn't know that, that's nice :)
EwenQuim
approved these changes
Jan 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation: I noticed some errors in the godoc, then I checked with revive and wow, so many things to fix