Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Struct-Based route Registration #93

Merged
merged 1 commit into from
Mar 30, 2024
Merged

Conversation

EwenQuim
Copy link
Member

@EwenQuim EwenQuim commented Mar 22, 2024

closes #71

All fields (ID...) are not currently implemented

@EwenQuim EwenQuim force-pushed the struct-based-registration branch from 45cd8c1 to 16b1cbd Compare March 22, 2024 02:18
@dylanhitt
Copy link
Collaborator

Will take a look tomorrow.

@EwenQuim
Copy link
Member Author

Thanks!

The PR is incomplete but the end result will look 80% like this.

Have a nice week-end too :)

@EwenQuim EwenQuim force-pushed the struct-based-registration branch from 16b1cbd to 16c858c Compare March 26, 2024 20:49
@EwenQuim
Copy link
Member Author

@dylanhitt ready for review if you have some time

Copy link
Collaborator

@dylanhitt dylanhitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Just that one comment. Feel free to resolve if you find it unnecessary.

@EwenQuim EwenQuim merged commit 836542a into main Mar 30, 2024
2 checks passed
@dylanhitt dylanhitt deleted the struct-based-registration branch April 4, 2024 01:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Struct-Based Operations
2 participants