Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding support for wasm/wasip1 #36

Merged
merged 2 commits into from
Oct 28, 2023
Merged

Adding support for wasm/wasip1 #36

merged 2 commits into from
Oct 28, 2023

Conversation

tryggvil
Copy link
Contributor

Adding support for compiling with GOOS=wasip1 and GOARCH=wasm

@tryggvil tryggvil mentioned this pull request Oct 12, 2023
Closed
@pjbgf
Copy link
Member

pjbgf commented Oct 13, 2023

Hey @tryggvil, thanks for your PR.

It would be good to add some tests for wasip1. For the current JS support, this is what we have: https://github.com/go-git/go-billy/blob/master/.github/workflows/test_js.yml

@HarikrishnanBalagopal HarikrishnanBalagopal mentioned this pull request Oct 21, 2023
Open
pjbgf
pjbgf approved these changes Oct 28, 2023
View reviewed changes
Copy link
Member

@pjbgf pjbgf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tryggvil thanks for working on this. 🙇

@pjbgf pjbgf merged commit b30fba3 into go-git:master Oct 28, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pjbgf pjbgf pjbgf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tryggvil @pjbgf