plumbing: Fix invalid reference name error while cloning branches con…

…taining /- (#1257) * plumbing: Fix invalid reference name error while cloning branches containing /- * Tests
go-git · Dec 20, 2024 · 62a77b7 · 62a77b7
1 parent 65f5e1a
commit 62a77b7
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/plumbing/reference.go b/plumbing/reference.go
@@ -188,7 +188,7 @@ func (r ReferenceName) Validate() error {
 
 	isBranch := r.IsBranch()
 	isTag := r.IsTag()
-	for _, part := range parts {
+	for i, part := range parts {
 		// rule 6
 		if len(part) == 0 {
 			return ErrInvalidReferenceName
@@ -205,7 +205,7 @@ func (r ReferenceName) Validate() error {
 			return ErrInvalidReferenceName
 		}
 
-		if (isBranch || isTag) && strings.HasPrefix(part, "-") { // branches & tags can't start with -
+		if (isBranch || isTag) && strings.HasPrefix(part, "-") && (i == 2) { // branches & tags can't start with -
 			return ErrInvalidReferenceName
 		}
 	}

diff --git a/plumbing/reference_test.go b/plumbing/reference_test.go
@@ -115,6 +115,8 @@ func (s *ReferenceSuite) TestValidReferenceNames(c *C) {
 		"refs/pulls/1/abc.123",
 		"refs/pulls",
 		"refs/-", // should this be allowed?
+		"refs/ab/-testing",
+		"refs/123-testing",
 	}
 	for _, v := range valid {
 		c.Assert(v.Validate(), IsNil)