Skip to content
This repository was archived by the owner on Dec 2, 2017. It is now read-only.

Add GITEA_CUSTOM configuration in customization section #111

Merged
merged 3 commits into from
Apr 12, 2017
Merged

Add GITEA_CUSTOM configuration in customization section #111

merged 3 commits into from
Apr 12, 2017

Conversation

blankoworld
Copy link
Contributor

Fix go-gitea/gitea#1452 about missing GITEA_CUSTOM explanation in documentation

Copy link
Member

@strk strk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check the resolution of custom/ dir

GITEA_CUSTOM=/srv/gitea/mycustom ./gitea web
```

**Note** that by default Gitea will use the `custom` folder in the current working directory.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm afraid at the moment it'll be the custom folder in the directory containing the gitea binary unless GITEA_WORK_DIR env is set, in which case that's the directory used to resolve relative paths like custom/

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right, I didn't be aware that GITEA_WORK_DIR variable exists.
That's why it should be better to create a specific subsection in this page to explain how GITEA_WORK_DIR and GITEA_CUSTOM works.
Or, in another case: create a specific page to list all available environment variable for GITEA?
What's your opinion about that?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes please add a section about env variables

@lunny lunny added the kind/docs label Apr 7, 2017
@lunny lunny added this to the 1.1 milestone Apr 7, 2017
@strk
Copy link
Member

strk commented Apr 7, 2017 via email

@lunny
Copy link
Member

lunny commented Apr 12, 2017

LGTM

@appleboy
Copy link
Member

LGTM

@appleboy appleboy merged commit 7ee0103 into go-gitea:master Apr 12, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants