This repository has been archived by the owner on Apr 12, 2019. It is now read-only.
Refactor CommitsBefore method to match github #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: David Schneiderbauer <dschneiderbauer@gmail.com>
bkcsoft
reviewed
Oct 12, 2017
repo_commit.go
Outdated
| return repo.commitsBefore(id, num) | ||
| } | ||
|
|
||
| func (repo *Repository) getBranches(commit *Commit) ([]string, error) { |
There was a problem hiding this comment.
Add a limit int so we can do for-each-ref --count=2 for the above command (L295) (makes it slightly more resiliant to branch-heavy repo)
|
Overall I think this is a very bad way of getting the list of commits. But fixing it properly would be harder to do in a single PR so LGTM |
|
@bkcsoft What would be a more sound approach in your opinion? Or should I create a new method to retrieve commits from the new branch? |
Signed-off-by: David Schneiderbauer <dschneiderbauer@gmail.com>
|
@daviian I'd check what branches we had before the push, and which ones we have after the push and then compare them. But that's a bit out-of-scope for this PR :) |
|
LGTM |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The CommitsBefore method is
onlyused to retrieve commits for the push webhook if a new branch is pushed.Namely at https://github.com/go-gitea/gitea/blob/a4cd4616c6f8524f8eb79d6184e855b3a8164130/models/update.go#L229
The refactored method now returns exactly those commits which were added in the new branch and are not existing in any other branch.
This result now behaves exactly as github (compared to the webhook result) except for the order.
The order will be fixed in a separate PR as there is another method which needs order fixing.
All these changes are necessary to implement go-gitea/gitea#2548