Fix page and missing return on unadopted repos API (#18848)

* Fix page and missing return on unadopted repos API

Page must be 1 if it's not specified and it should return after sending an internal server error.

* Allow ignore pages

Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>

integrations/api_repo_test.go

@@ -468,7 +468,6 @@ func TestAPIRepoTransfer(t *testing.T) {
  expectedStatus int
  }{
  // Disclaimer for test story: "user1" is an admin, "user2" is normal user and part of in owner team of org "user3"
-
  // Transfer to a user with teams in another org should fail
  {ctxUserID: 1, newOwner: "user3", teams: &[]int64{5}, expectedStatus: http.StatusForbidden},
  // Transfer to a user with non-existent team IDs should fail

models/migrations/migrations.go

@@ -61,7 +61,6 @@ type Version struct {
 // update minDBVersion accordingly
 var migrations = []Migration{
  // Gitea 1.5.0 ends at v69
-
  // v70 -> v71
  NewMigration("add issue_dependencies", addIssueDependencies),
  // v71 -> v72

routers/api/v1/admin/adopt.go

@@ -43,9 +43,13 @@ func ListUnadoptedRepositories(ctx *context.APIContext) {
  // "$ref": "#/responses/forbidden"
 
  listOptions := utils.GetListOptions(ctx)
+ if listOptions.Page == 0 {
+ listOptions.Page = 1
+ }
  repoNames, count, err := repo_service.ListUnadoptedRepositories(ctx.FormString("query"), &listOptions)
  if err != nil {
  ctx.InternalServerError(err)
+ return
  }
 
  ctx.SetTotalCountHeader(int64(count))