Fix successful return value for SyncAndGetUserSpecificDiff (#27152) (#27156)

GiteaBot · delvh · web-flow · commit 25233a9bdcfd · 2023-09-21T00:58:13.000+02:00
Backport #27152 by @delvh A function should not return an error when it is successful. Otherwise, things like https://discord.com/channels/322538954119184384/322538954119184384/1153705341620600833 happen… Co-authored-by: delvh <dev.lh@web.de>
diff --git a/services/gitdiff/gitdiff.go b/services/gitdiff/gitdiff.go
@@ -1312,7 +1312,7 @@ outer:
 		}
 	}
 
-	return diff, err
+	return diff, nil
 }
 
 // CommentAsDiff returns c.Patch as *Diff

Original file line number	Diff line number	Diff line change
`@@ -1312,7 +1312,7 @@ outer:`
`1312`	`1312`	`}`
`1313`	`1313`	`}`
`1314`	`1314`
`1315`		`- return diff, err`
	`1315`	`+ return diff, nil`
`1316`	`1316`	`}`
`1317`	`1317`
`1318`	`1318`	`// CommentAsDiff returns c.Patch as *Diff`