Skip to content

Commit

Permalink
Release page show all tags in compare dropdown (#20070) (#20072)
Browse files Browse the repository at this point in the history
Backport #20070 

Just get all tags when creating the compare dropdown.

Fix #19936
  • Loading branch information
6543 authored Jun 21, 2022
1 parent 710a141 commit 29ac316
Showing 1 changed file with 8 additions and 1 deletion.
9 changes: 8 additions & 1 deletion routers/web/repo/release.go
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,14 @@ func releasesOrTags(ctx *context.Context, isTagList bool) {
listOptions.PageSize = setting.API.MaxResponseItems
}

tags, err := ctx.Repo.GitRepo.GetTags(listOptions.GetStartEnd())
// TODO(20073) tags are used for compare feature witch needs all tags
// filtering is doen at the client side atm
tagListStart, tagListEnd := 0, 0
if isTagList {
tagListStart, tagListEnd = listOptions.GetStartEnd()
}

tags, err := ctx.Repo.GitRepo.GetTags(tagListStart, tagListEnd)
if err != nil {
ctx.ServerError("GetTags", err)
return
Expand Down

0 comments on commit 29ac316

Please sign in to comment.