Skip to content

Commit

Permalink
Remove jQuery .attr from the quick pull request button text (#29916)
Browse files Browse the repository at this point in the history
- Switched from jQuery `.attr` to plain javascript `.getAttribute`
- Tested the quick pull request button text change functionality and it
works as before

Signed-off-by: Yarden Shoham <git@yardenshoham.com>
  • Loading branch information
yardenshoham authored Mar 19, 2024
1 parent 55a8f45 commit 4cfda02
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion web_src/js/features/repo-editor.js
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ export function initRepoEditor() {
hideElem($('.quick-pull-branch-name'));
document.querySelector('.quick-pull-branch-name input').required = false;
}
$('#commit-button').text($(this).attr('button_text'));
$('#commit-button').text(this.getAttribute('button_text'));
});

const joinTreePath = ($fileNameEl) => {
Expand Down

0 comments on commit 4cfda02

Please sign in to comment.