Remove jQuery .attr from the quick pull request button text (#29916)

yardenshoham · web-flow · commit 4cfda0241993 · 2024-03-19T23:44:21.000Z
- Switched from jQuery `.attr` to plain javascript `.getAttribute`
- Tested the quick pull request button text change functionality and it
works as before

Signed-off-by: Yarden Shoham &lt;git@yardenshoham.com&gt;
diff --git a/web_src/js/features/repo-editor.js b/web_src/js/features/repo-editor.js
@@ -72,7 +72,7 @@ export function initRepoEditor() {
       hideElem($('.quick-pull-branch-name'));
       document.querySelector('.quick-pull-branch-name input').required = false;
     }
-    $('#commit-button').text($(this).attr('button_text'));
+    $('#commit-button').text(this.getAttribute('button_text'));
   });
 
   const joinTreePath = ($fileNameEl) => {

Original file line number	Diff line number	Diff line change
`@@ -72,7 +72,7 @@ export function initRepoEditor() {`
`72`	`72`	`hideElem($('.quick-pull-branch-name'));`
`73`	`73`	`document.querySelector('.quick-pull-branch-name input').required = false;`
`74`	`74`	`}`
`75`		`- $('#commit-button').text($(this).attr('button_text'));`
	`75`	`+ $('#commit-button').text(this.getAttribute('button_text'));`
`76`	`76`	`});`
`77`	`77`
`78`	`78`	`const joinTreePath = ($fileNameEl) => {`