Skip to content

Commit 53b609e

Browse files
authored
Fix JS error on compare page (#23551)
Fix regression from #23271. This code apparently runs on the compare page where there is no review button so check for existance of both button and content. <img width="1226" alt="Screenshot 2023-03-17 at 21 42 47" src="https://user-images.githubusercontent.com/115237/226040001-ec097edd-d926-4c80-9962-526f9b7eff19.png"> Fixes #23562
1 parent 7eede7f commit 53b609e

File tree

1 file changed

+15
-13
lines changed

1 file changed

+15
-13
lines changed

Diff for: web_src/js/features/repo-issue.js

+15-13
Original file line numberDiff line numberDiff line change
@@ -516,20 +516,22 @@ export function initRepoPullRequestReview() {
516516
const $panel = $reviewBtn.parent().find('.review-box-panel');
517517
const $closeBtn = $panel.find('.close');
518518

519-
const tippy = createTippy($reviewBtn[0], {
520-
content: $panel[0],
521-
placement: 'bottom',
522-
trigger: 'click',
523-
role: 'menu',
524-
maxWidth: 'none',
525-
interactive: true,
526-
hideOnClick: true,
527-
});
519+
if ($reviewBtn.length && $panel.length) {
520+
const tippy = createTippy($reviewBtn[0], {
521+
content: $panel[0],
522+
placement: 'bottom',
523+
trigger: 'click',
524+
role: 'menu',
525+
maxWidth: 'none',
526+
interactive: true,
527+
hideOnClick: true,
528+
});
528529

529-
$closeBtn.on('click', (e) => {
530-
e.preventDefault();
531-
tippy.hide();
532-
});
530+
$closeBtn.on('click', (e) => {
531+
e.preventDefault();
532+
tippy.hide();
533+
});
534+
}
533535

534536
$(document).on('click', 'a.add-code-comment', async function (e) {
535537
if ($(e.target).hasClass('btn-add-single')) return; // https://github.com/go-gitea/gitea/issues/4745

0 commit comments

Comments
 (0)