Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unable to create a pull request in try.gitea.io #23562

Closed
Deilan opened this issue Mar 18, 2023 · 1 comment · Fixed by #23551
Closed

Unable to create a pull request in try.gitea.io #23562

Deilan opened this issue Mar 18, 2023 · 1 comment · Fixed by #23551
Labels
type/bug

Comments

@Deilan
Copy link

Deilan commented Mar 18, 2023

Description

Unable to create a pull request in try.gitea.io

Browser console:

DevTools failed to load source map: Could not load content for chrome-extension://cfhdojbkjhnklbpkdaibdccddilifddb/browser-polyfill.js.map: System error: net::ERR_FILE_NOT_FOUND
jquery.js:4086 jQuery.Deferred exception: Cannot read properties of undefined (reading 'getAttribute') TypeError: Cannot read properties of undefined (reading 'getAttribute')
    at Dr (https://try.gitea.io/assets/js/index.js?v=1.20.0~dev-209-g48f6805b0:31:21011)
    at _v (https://try.gitea.io/assets/js/index.js?v=1.20.0~dev-209-g48f6805b0:61:24253)
    at HTMLDocument.<anonymous> (https://try.gitea.io/assets/js/index.js?v=1.20.0~dev-209-g48f6805b0:102:10906)
    at ui (https://try.gitea.io/assets/js/index.js?v=1.20.0~dev-209-g48f6805b0:12:46510)
    at qn (https://try.gitea.io/assets/js/index.js?v=1.20.0~dev-209-g48f6805b0:12:46862) undefined
d.Deferred.exceptionHook @ jquery.js:4086
qn @ jquery.js:3874
setTimeout (async)
(anonymous) @ jquery.js:3908
Be @ jquery.js:3536
fireWith @ jquery.js:3666
fire @ jquery.js:3674
Be @ jquery.js:3536
fireWith @ jquery.js:3666
ready @ jquery.js:4146
pt @ jquery.js:4156
tippy.js:6 Uncaught TypeError: Cannot read properties of undefined (reading 'getAttribute')
    at Dr (tippy.js:6:23)
    at _v (repo-issue.js:519:17)
    at HTMLDocument.<anonymous> (index.js:178:3)
    at ui (jquery.js:3802:29)
    at qn (jquery.js:3870:12)

Gitea Version

1.20.0+dev-209-g48f6805b0

Can you reproduce the bug on the Gitea demo site?

Yes

Log Gist

No response

Screenshots

image

Git Version

No response

Operating System

No response

How are you running Gitea?

https://try.gitea.io/

Database

None
@delvh delvh mentioned this issue Mar 18, 2023
Merged
@silverwind
Copy link
Member

Will be fixed with #23551 shortly.

delvh pushed a commit that referenced this issue Mar 18, 2023
@silverwind
Fix JS error on compare page (#23551)
53b609e 
Fix regression from #23271.
This code apparently runs on the compare page where there is no review button so check for existance of both button and content.

<img width="1226" alt="Screenshot 2023-03-17 at 21 42 47"
src="https://user-images.githubusercontent.com/115237/226040001-ec097edd-d926-4c80-9962-526f9b7eff19.png">

Fixes #23562
@GiteaBot GiteaBot mentioned this issue Mar 18, 2023
Merged
GiteaBot pushed a commit to GiteaBot/gitea that referenced this issue Mar 18, 2023
@silverwind @GiteaBot
Fix JS error on compare page (go-gitea#23551)
2482db9 
Fix regression from go-gitea#23271.
This code apparently runs on the compare page where there is no review button so check for existance of both button and content.

<img width="1226" alt="Screenshot 2023-03-17 at 21 42 47"
src="https://user-images.githubusercontent.com/115237/226040001-ec097edd-d926-4c80-9962-526f9b7eff19.png">

Fixes go-gitea#23562
jolheiser pushed a commit that referenced this issue Mar 18, 2023
@GiteaBot @silverwind
Fix JS error on compare page (#23551) (#23566)
1a97a84 
Backport #23551 by @silverwind

Fix regression from #23271. This
code apparently runs on the compare page where there is no review button
so check for existance of both button and content.

<img width="1226" alt="Screenshot 2023-03-17 at 21 42 47"
src="https://user-images.githubusercontent.com/115237/226040001-ec097edd-d926-4c80-9962-526f9b7eff19.png">

Fixes #23562

Co-authored-by: silverwind <me@silverwind.io>
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
type/bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix JS error on compare page silverwind/gitea
2 participants
@silverwind @Deilan