Skip to content

Commit

Permalink
fix: use Base36 for all code indexers (#12830)
Browse files Browse the repository at this point in the history
  • Loading branch information
jnlin authored Sep 14, 2020
1 parent 53b6565 commit 6c4e962
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 6 deletions.
5 changes: 0 additions & 5 deletions modules/indexer/code/bleve.go
Original file line number Diff line number Diff line change
Expand Up @@ -37,11 +37,6 @@ import (
const unicodeNormalizeName = "unicodeNormalize"
const maxBatchSize = 16

// indexerID a bleve-compatible unique identifier for an integer id
func indexerID(id int64) string {
return strconv.FormatInt(id, 36)
}

// numericEqualityQuery a numeric equality query for the given value and field
func numericEqualityQuery(value int64, field string) *query.NumericRangeQuery {
f := float64(value)
Expand Down
6 changes: 5 additions & 1 deletion modules/indexer/code/indexer.go
Original file line number Diff line number Diff line change
Expand Up @@ -51,12 +51,16 @@ func filenameIndexerID(repoID int64, filename string) string {
return indexerID(repoID) + "_" + filename
}

func indexerID(id int64) string {
return strconv.FormatInt(id, 36)
}

func parseIndexerID(indexerID string) (int64, string) {
index := strings.IndexByte(indexerID, '_')
if index == -1 {
log.Error("Unexpected ID in repo indexer: %s", indexerID)
}
repoID, _ := strconv.ParseInt(indexerID[:index], 10, 64)
repoID, _ := strconv.ParseInt(indexerID[:index], 36, 64)
return repoID, indexerID[index+1:]
}

Expand Down

0 comments on commit 6c4e962

Please sign in to comment.