Skip to content

Commit

Permalink
Fix broken image when editing comment with non-image attachments (#32319
Browse files Browse the repository at this point in the history
) (#32345)

Backport #32319 

Fix #32316

---------

Co-authored-by: yp05327 <576951401@qq.com>
  • Loading branch information
lunny and yp05327 authored Nov 2, 2024
1 parent 898f852 commit a3b7b98
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 2 deletions.
7 changes: 5 additions & 2 deletions web_src/js/features/repo-issue-edit.js
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ import {getComboMarkdownEditor, initComboMarkdownEditor} from './comp/ComboMarkd
import {createDropzone} from './dropzone.js';
import {GET, POST} from '../modules/fetch.js';
import {hideElem, showElem} from '../utils/dom.js';
import {isImageFile} from '../utils/image.js';
import {attachRefIssueContextPopup} from './contextpopup.js';
import {initCommentContent, initMarkupContent} from '../markup/content.js';

Expand Down Expand Up @@ -84,10 +85,12 @@ async function onEditContent(event) {
for (const attachment of data) {
const imgSrc = `${dropzone.getAttribute('data-link-url')}/${attachment.uuid}`;
dz.emit('addedfile', attachment);
dz.emit('thumbnail', attachment, imgSrc);
if (isImageFile(attachment.name)) {
dz.emit('thumbnail', attachment, imgSrc);
dropzone.querySelector(`img[src='${imgSrc}']`).style.maxWidth = '100%';
}
dz.emit('complete', attachment);
fileUuidDict[attachment.uuid] = {submitted: true};
dropzone.querySelector(`img[src='${imgSrc}']`).style.maxWidth = '100%';
const input = document.createElement('input');
input.id = attachment.uuid;
input.name = 'files';
Expand Down
4 changes: 4 additions & 0 deletions web_src/js/utils/image.js
Original file line number Diff line number Diff line change
Expand Up @@ -45,3 +45,7 @@ export async function imageInfo(blob) {

return {width, dppx};
}

export function isImageFile(name) {
return /\.(jpe?g|png|gif|webp|svg|heic)$/i.test(name);
}

0 comments on commit a3b7b98

Please sign in to comment.