rearrange NotFound call

go-gitea · Feb 26, 2024 · f6b68be · f6b68be
1 parent 7c2cb4b
commit f6b68be
Showing 1 changed file with 1 addition and 5 deletions.
diff --git a/routers/web/explore/user.go b/routers/web/explore/user.go
@@ -86,6 +86,7 @@ func RenderUserSearch(ctx *context.Context, opts *user_model.SearchUserOptions,
 	}
 
 	if opts.SupportedSortOrders != nil && !opts.SupportedSortOrders.Contains(sortOrder) {
+		ctx.NotFound("unsupported sort order", nil)
 		return
 	}
 
@@ -150,11 +151,6 @@ func Users(ctx *context.Context) {
 		ctx.SetFormString("sort", sortOrder)
 	}
 
-	if !supportedSortOrders.Contains(sortOrder) {
-		ctx.NotFound("unsupported sort order", nil)
-		return
-	}
-
 	RenderUserSearch(ctx, &user_model.SearchUserOptions{
 		Actor:       ctx.Doer,
 		Type:        user_model.UserTypeIndividual,