Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stars tab in user page exposes number of starred private repos #11949

Closed
2 of 7 tasks
archer-321 opened this issue Jun 18, 2020 · 0 comments
Closed
2 of 7 tasks

Stars tab in user page exposes number of starred private repos #11949

archer-321 opened this issue Jun 18, 2020 · 0 comments
Labels
type/bug

Comments

@archer-321
Copy link
Contributor

  • Gitea version (or commit ref): 1.11.6
  • Git version: 2.27.0
  • Operating system: GNU/Linux
  • Database (use [x]):
    • PostgreSQL
    • MySQL
    • MSSQL
    • SQLite
  • Can you reproduce the bug at https://try.gitea.io:
  • Log gist: I can't get a log gist as I don't have access to the server's logs.

Description

Steps to reproduce

  • Create a private repository
  • Star this repository
  • Log out or open a private tab
  • Open the user's profile page with the stars tab (e.g. https://gitea.tld/user?tab=stars)

If a user stars a private repository, it still shows up as a little one in the starred page overview.
This doesn't expose too much private information, but it's confusing to see that one project is starred whilst seeing an empty list in the overview.

Screenshots

Screenshot from 2020-06-18 14-26-55
@lunny lunny added the type/bug label Jun 18, 2020
a1012112796 added a commit to a1012112796/gitea that referenced this issue Jun 18, 2020
@a1012112796
Decrease the num_stars when deleting a repo
67d90e7 
fix go-gitea#11949

Signed-off-by: a1012112796 <1012112796@qq.com>
@a1012112796 a1012112796 mentioned this issue Jun 18, 2020
Merged
a1012112796 added a commit to a1012112796/gitea that referenced this issue Jul 8, 2020
@a1012112796 @lafriks
@zeripath @lunny
Decrease the num_stars when deleting a repo (go-gitea#11954)
a3ef509 
* Decrease the  num_stars when deleting a repo

fix go-gitea#11949

Signed-off-by: a1012112796 <1012112796@qq.com>

* Add migration

* use batch

* Apply suggestions from code review

Co-authored-by: Lauris BH <lauris@nix.lv>

* fix lint

* fix lint

* fix ci

* fix ci2

* add doctor

* duplicate code

* fix migration

* fix some nits

* add start

Co-authored-by: Lauris BH <lauris@nix.lv>
Co-authored-by: zeripath <art27@cantab.net>
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
techknowlogick pushed a commit that referenced this issue Jul 8, 2020
@a1012112796 @lafriks
@zeripath @lunny
Decrease the num_stars when deleting a repo (#11954) (#12188)
6a081f9 
* Decrease the  num_stars when deleting a repo

fix #11949

Signed-off-by: a1012112796 <1012112796@qq.com>

* Add migration

* use batch

* Apply suggestions from code review

Co-authored-by: Lauris BH <lauris@nix.lv>

* fix lint

* fix lint

* fix ci

* fix ci2

* add doctor

* duplicate code

* fix migration

* fix some nits

* add start

Co-authored-by: Lauris BH <lauris@nix.lv>
Co-authored-by: zeripath <art27@cantab.net>
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>

Co-authored-by: Lauris BH <lauris@nix.lv>
Co-authored-by: zeripath <art27@cantab.net>
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
ydelafollye pushed a commit to ydelafollye/gitea that referenced this issue Jul 31, 2020
@a1012112796 @lafriks
@zeripath @lunny
Decrease the num_stars when deleting a repo (go-gitea#11954)
1e35e98 
* Decrease the  num_stars when deleting a repo

fix go-gitea#11949

Signed-off-by: a1012112796 <1012112796@qq.com>

* Add migration

* use batch

* Apply suggestions from code review

Co-authored-by: Lauris BH <lauris@nix.lv>

* fix lint

* fix lint

* fix ci

* fix ci2

* add doctor

* duplicate code

* fix migration

* fix some nits

* add start

Co-authored-by: Lauris BH <lauris@nix.lv>
Co-authored-by: zeripath <art27@cantab.net>
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
type/bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lunny @archer-321