Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Regression: Gitea commits API again returns commit summaries, not full messages #12185

Closed
kbadk opened this issue Jul 8, 2020 · 0 comments · Fixed by #12186
Closed

Regression: Gitea commits API again returns commit summaries, not full messages #12185

kbadk opened this issue Jul 8, 2020 · 0 comments · Fixed by #12186

Comments

@kbadk
Copy link
Contributor

kbadk commented Jul 8, 2020

In April 2019, this same issue was brought up.

It was deemed a bug, added to the 1.8.0 milestone, implemented the same day, and made it into v1.8.

release/v1.8:

gitea/routers/api/v1/repo/commits.go

Line 109 in 11f6ed4

Message: commit.Message(),

Where it lived happily (through release/v1.9) until this commit: API method to list all commits of a repository (#6408).

In v1.10 and v1.11 (and the current HEAD of master), however, we're back to commit.Summary().

release/v1.10:

gitea/routers/api/v1/repo/commits.go

Line 277 in 4d876ab

Message: commit.Summary(),

I don't see an explanation for this, so I'm assuming it's a regression.
@kbadk kbadk mentioned this issue Jul 8, 2020
Merged
zeripath pushed a commit that referenced this issue Jul 8, 2020
@kbadk
Fix regression: Gitea commits API again returns commit summaries, not…
cedbd36 
… full messages (#12186)

Closes #12185
techknowlogick pushed a commit to techknowlogick/gitea that referenced this issue Jul 8, 2020
@kbadk @techknowlogick
Fix regression: Gitea commits API again returns commit summaries, not…
7ce8bb2 
… full messages (go-gitea#12186)

Closes go-gitea#12185
techknowlogick added a commit that referenced this issue Jul 8, 2020
@techknowlogick @kbadk
Fix regression: Gitea commits API again returns commit summaries, not…
c3c246c 
… full messages (#12186) (#12187)

Closes #12185

Co-authored-by: Kristian Antonsen <kristian@derfor.dk>
ydelafollye pushed a commit to ydelafollye/gitea that referenced this issue Jul 31, 2020
@kbadk
Fix regression: Gitea commits API again returns commit summaries, not…
bb4c84b 
… full messages (go-gitea#12186)

Closes go-gitea#12185
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Regression: Gitea commits API again returns commit summaries, not full messages
1 participant
@kbadk